fix: when docker build in arm or other not amd64 env.#2492
Merged
Conversation
Signed-off-by: yanggang <gang.yang@daocloud.io>
yanggangtony
changed the title
sozercan
reviewed
Jan 4, 2023
|
|
||
| # Install ORAS | ||
| RUN curl -SsLO https://github.com/oras-project/oras/releases/download/v${ORAS_VERSION}/oras_${ORAS_VERSION}_linux_amd64.tar.gz && \ | ||
| RUN curl -SsLO https://github.com/oras-project/oras/releases/download/v${ORAS_VERSION}/oras_${ORAS_VERSION}_linux_${arch}.tar.gz && \ |
Member
There was a problem hiding this comment.
can we use TARGETARCH here? https://www.docker.com/blog/faster-multi-platform-builds-dockerfile-cross-compilation-guide/
Contributor
Author
There was a problem hiding this comment.
thanks for the advice.
I search the web , docker automatic-platform-args-in-the-global-scope.
It says
Automatic platform ARGs in the global scope
This feature is only available when using the [BuildKit](https://docs.docker.com/build/buildkit/) backend.
perhaps in docker build mod , it will no works for ..
maxsmythe
approved these changes
Jan 5, 2023
Contributor
maxsmythe
left a comment
maxsmythe
left a comment
There was a problem hiding this comment.
Thanks! LGTM, pending sozercan@'s thumbs up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yanggang gang.yang@daocloud.io
What this PR does / why we need it:
/kind bug
Special notes for your reviewer:
When build in arm env , will error , because the
RUN curl oras , yghave the constant string 'amd64'.oras >=0.11.1 , have the arm libs.
yg release also have the arm libs.